[Ruby] Support "binary" format for body parameter and response #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {{/bodyParam}} | ||
|
|
||
| {{/bodyParam}}{{#bodyParam}}{{#isBinary}}post_body = {{#required}}{{{paramName}}}{{/required}}{{^required}}opts[:'{{{paramName}}}']{{/required}} | ||
| post_body = post_body.pack('C*') if post_body |
There was a problem hiding this comment.
Nearly the same comment from https://github.com/swagger-api/swagger-codegen/pull/1891/files#diff-630a0645a0b3fabb89412db600734cfbR245
A array of 8bit ints is a very non-standard data format in Ruby. As a user, I would prefer post_body here without processing.
as it seems weird to handle byte array (array of integer) in Ruby
xhh
changed the title
xhh
changed the title
Conflicts: samples/client/petstore/ruby/lib/petstore/api/pet_api.rb
|
@jqr the PR has been updated to use string instead of array of integer to represent byte array. |
wing328
added a commit
that referenced
this pull request
Jan 29, 2016
[Ruby] Support "binary" format for body parameter and response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "binary" format is handled as String in Ruby client.