Skip to content

Update Swagger Codegen to v1.5.15 #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Update Swagger Codegen to v1.5.15 #5858

merged 3 commits into from
Jun 26, 2017

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Jun 16, 2017

Fixes #5753

Updates swagger-core, swagger-parser to the latest production versions

@wing328 wing328 closed this Jun 21, 2017
@wing328 wing328 reopened this Jun 21, 2017
@wing328
Copy link
Contributor

wing328 commented Jun 26, 2017

@fehguy did some tests and found that there are changes to type: string, format: byte. Here is an example for the C# Petstore samples with fake endpoints.

@@ -149,7 +149,7 @@ namespace IO.Swagger.Model
         /// Gets or Sets _Byte
         /// </summary>
         [DataMember(Name="byte", EmitDefaultValue=false)]
-        public byte[] _Byte { get; set; }
+        public string _Byte { get; set; }

Other generators (e.g. PHP, Ruby, Python, etc) experience similar changes.

It seems like the format: byte is ignored, and here is the definition of the parameter:

        - name: byte
          type: string
          format: byte
          in: formData
          description: None
          required: true

@wing328 wing328 changed the title updated versions Update Swagger Codegen to v1.5.15 Jun 26, 2017
@fehguy
Copy link
Contributor Author

fehguy commented Jun 26, 2017

Thanks I'll look into this

@fehguy fehguy merged commit 62c0f17 into master Jun 26, 2017
@fehguy fehguy deleted the issue-5753 branch June 26, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants