Handle untyped schemas #6898
Open
Handle untyped schemas #6898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibson042 thanks for the PR. We'll wait for swagger-api/swagger-parser#573 to be merged first. |
|
@wing328 any update on this one? Seems to be the root problem of (only the Java client ones): |
gibson042
force-pushed
the
gh-6896-untyped
branch
from
8bacdb0 to
9568fdb
Compare
|
@wing328 This should now be good to go. |
|
@gibson042 thanks for tagging me but I'm no longer involved in this project. I hope others will be able to help you out. Good luck. |
gibson042
added a commit
to gibson042/openapi-generator
that referenced
this pull request
Sep 21, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6896
Depends upon swagger-api/swagger-parser#573
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
As a foundation for #6896, treat untyped schemas like
type: object(since many languages have a root type, and even those that don't are fairly well-behaved here) and save language-specific work for later.