Skip to content

Conversation

endrec
Copy link

@endrec endrec commented Feb 9, 2018

Description of the PR

Filtering out missing operations from the returned array (see issue #7007 )

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Contributor

wing328 commented Feb 13, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@endrec
Copy link
Author

endrec commented Feb 13, 2018

Oh, the beauty of too many email addresses. :) Should be connected now, thanks for letting me know.

@wing328 wing328 added this to the v3.0.0 milestone Feb 18, 2018
@HugoMario HugoMario mentioned this pull request Jun 6, 2019
4 tasks
@HugoMario HugoMario merged commit 77ef153 into swagger-api:3.0.0 Jun 7, 2019
@HugoMario
Copy link
Contributor

thanks a lot @endrec , and sorry for this too long delay

@endrec
Copy link
Author

endrec commented Jun 7, 2019

No worries. :)

@endrec endrec deleted the 3.0.0 branch June 7, 2019 21:11
@endrec endrec restored the 3.0.0 branch June 7, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants