add binary type #7902
Closed
add binary type #7902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given there is no influence on the generated client, the tests might just not cover this use-case. Can you reproduce #2305 in a form of a test? |
|
hi @frol , that's a great suggestion, I'll work on that ! |
|
generator class was moved to a different repo, however, changes from this PR were migrated with swagger-api/swagger-codegen-generators#510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is my humble try to implement a portable python binary stream typemapping. As far as I can teel, this should be non-breaking because six, and could maybe fix #2305 and other py3 encoding-related issues.
For me, this is a sideproduct developed for unlocking kubernetes-client/python#494 as per #7900, altough specific patch for kubeclient will live in 676da33 because local python generator choices.
Tests went ok, but maybe you could help me point out if more are required.
Thank you, regards
/cc @taxpon @frol @mbohlool @cbornet @kenjones-cisco