Skip to content

[Java] Make API client more pluggable #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2015
Merged

[Java] Make API client more pluggable #791

merged 7 commits into from
Jun 5, 2015

Conversation

xhh
Copy link
Contributor

@xhh xhh commented May 26, 2015

Make ApiClient (ApiInvoker before) more pluggable for Java clients, similar to what has been done to PHP and Python clients (#778, #787), and follow suggestions from #786 on naming.

  • Rename ApiInvoker to ApiClient
  • Make ApiClient pluggable by allowing setting the ApiClient field of
    API classes
  • Introduce a Configuration class, containing the default
    ApiClient (which is also customizable)
  • Move basePath from API class to ApiClient
  • Change static methods in ApiClient to instance level

@who
Copy link
Contributor

who commented May 26, 2015

👍

xhh added 4 commits May 29, 2015 12:08
- Rename ApiInvoker to ApiClient
- Make ApiClient pluggable by allowing setting the ApiClient field of
  API classes
- Introduce a Configuration class, containing the default
  ApiClient (which is also customizable)
- Move basePath from API class to ApiClient
- Change static methods in ApiClient to instance level
@olensmar
Copy link
Contributor

olensmar commented Jun 2, 2015

please rebase so we can merge...

Conflicts:
	modules/swagger-codegen/src/main/java/com/wordnik/swagger/codegen/languages/JavaClientCodegen.java
@xhh
Copy link
Contributor Author

xhh commented Jun 2, 2015

@olensmar it is done

xhh added 2 commits June 3, 2015 10:09
and fix the bug of getting file name for file parameter
fehguy added a commit that referenced this pull request Jun 5, 2015
[Java] Make API client more pluggable
@fehguy fehguy merged commit aecb4ad into swagger-api:develop_2.0 Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants