C++ codegen improvements #9427
Open
C++ codegen improvements #9427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of the C++ codegens can create invalid C++ type identifiers. For example, if the definition name includes dots or hypens. This commit fixes this by sanitizing the definition names before being provided for templating. In addition, the type names are camel cased, as proscribed by the C++ styleguide.
- Moving duplicated C++ codegen functionality into AbstractCppCodegen. - Various linting fixes.
Added to AbstractCppCodegen to include support or all C++ codegen clients. Qt overwrites this with its own mapping.
mjjbell
force-pushed
the
cpprest_type_sanitation
branch
from
00a0cbe to
990c328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@fvarose
Description of the PR
(The PR will be easier to understand by reviewing the commits separately)
There is no change to the Petstore sample other than the version being used to generate the code, so I have omitted this.