[PHP] Support for customizing namespace and Composer fields#977
Merged
Conversation
Contributor
Author
|
Here is an example of what this PR allows, given the petstore 2.0 spec: Given this config json... ... this is the swagger-codegen output ... ... and this is the file tree of generated output ... ... and this is the composer.json: |
Contributor
Author
|
@wing328 let me know if you need me to elaborate on any of this. |
Contributor
|
@who thanks for the PR! I'll review and let you know if I've any questions. |
Contributor
|
Unit testing looks good: Tested with the config json provided and the result also looks good. |
wing328
added a commit
that referenced
this pull request
Jul 15, 2015
[PHP] Support for customizing namespace and Composer fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've improved the configuration file support in the PHP codegen so that composer vendor name, composer project name, composer version, and namespace are all configurable.
Here's the new output of the config-help for php: