Enable submitting cookies in CORS requests

[renuka-fernando]

Changes

• Change the value of credentials according to the value of http.withCredentials as in the README.md.

Description

• Change the value of credentials if http.withCredentials value is true.

Motivation and Context

• The issue is credentials is always 'same-origin' to fetch request.
• Cookies are not stored nor submitted across different origins.
• Fixes In CORS requests Cookies are not submitted nor setting correctly #1186

How Has This Been Tested?

• Tested with two origins.
• UI running on localhost:9292 sends requests to the server on localhost:9293.

Screenshots (if appropriate):

• Video on testing the fix: Testing swagger-js submitting cookies within two origins.
• Set cookies
  

Types of changes

• No code changes (changes to documentation, CI, metadata, etc)
• Dependency changes (any modification to dependencies in package.json)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[shockey]

@RenukaFernando, can you add some tests to cover this new functionality?

[renuka-fernando]

Hi @shockey,
As per our understanding, writing unit tests for this improvement is troublesome. Can you please help writing integration tests on this?
So then this can be merged.

[shockey]

@RenukaFernando can do!

[shockey]

thanks, @RenukaFernando!

[renuka-fernando]

Thank you! @shockey for you help

[renuka-fernando]

Hi @shockey,
We are still facing the issue of handling CORS request. #1236 is fixed the issue and we have tested it with two origins.

Can you please review it?

[dalbani]

Hi, maybe a silly question, but could someone explain me how to set this http.withCredentials flag in the context of SwaggerUIBundle (i.e. when deploying Swagger UI as shown on https://github.com/swagger-api/swagger-ui/blob/master/dist/index.html#L41)?

[shockey]

@dalbani, this is a merged PR - if you need help please open a new support ticket 👍