Skip to content

Draft: Update debug scenario and robot detail modal #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Apr 12, 2025

  • rename to debug.yaml to match scenario name
  • tweak the map so that it is easier to see where the robot should crash
  • change the crashed robot log hint so that it does not have line breaks inside sentences
  • change hint robot code so that it does not spam logs
  • use more available space in the robot detail pane to make the log readable - closes Improve layout/use of space in Robots (F2) dialog #2228
  • use hexadecimal time format in Tick pretty instance
  • part of Tutorial play test Mega Issue #2392

* rename to debug.yaml to match scenario name
* tweak map so that it is easier to see where the robot should crash
* change crashed robot log hint so that it does not have line breaks
  inside sentences
* change hint robot code, so that it does not spam logs
* use more available space in robot detail pane to make the log readable
* use hexadecimal time format in `Tick` pretty instance
@xsebek xsebek added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Apr 12, 2025
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played through the improved tutorial and it works well!

iterate n com;
end;

tydef RobotState = [gave_win: Bool, said_log_missing: Bool, said_loc: (Int * Int)] end;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh records 💿

@byorgey
Copy link
Member

byorgey commented Apr 12, 2025

Looks like the CI is failing because test/integration/Main.hs still refers to Tutorials/crash instead of Tutorials/debug.

@xsebek xsebek changed the title Update debug scenario and robot detail modal Draft: Update debug scenario and robot detail modal Apr 12, 2025
@xsebek
Copy link
Member Author

xsebek commented Apr 12, 2025

I will add a few more improvements, stay tuned! 📀

zoomRobots $ do
removeRobotFromLocationMap oldLoc rid
addRobotToLocation rid newlocWithPortal
unless invis $ wakeWatchingRobots rid t newLoc
Copy link
Member Author

@xsebek xsebek Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostmo I would like to change the watch to also notice robots. I want to avoid system robots having to busy-wait, and this would help a lot.

But to do this radical change, I would need help. Four challenges that use watch fail with this change, and I am unable to decipher how they work:

  • Challenges/gopher
  • Challenges/Sliding Puzzles/3x3
  • Challenges/Ranching/capture
  • Challenges/Sokoban/foresight.yaml

Could you please check if the solutions could work with waking by (visible) robots?


I thought about making a new command for compatibility, but that would need a new watch map. If possible, I would like to avoid the mental overload of too many commands both for players and developers.

Comment on lines +8 to +9
Before you send your robots far away from the `base` you need to learn how
to figure out what went wrong with them if they crash.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byorgey I am considering adding an objective to salvage a built robot in the same space first.
I worry that this scenario teaches too much at once.

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think that makes sense.

mergify bot pushed a commit that referenced this pull request May 19, 2025
* rename to debug.yaml to match scenario name
* tweak the map so that it is easier to see where the robot should crash
* change the crashed robot log hint so that it does not have line breaks inside sentences
* change hint robot code so that it does not spam logs
* use hexadecimal time format in `Tick` pretty instance
* use more available space in the robot detail pane to make the log readable
* closes #2228 
* part of #2392
* split from #2395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve layout/use of space in Robots (F2) dialog
2 participants