`console?.log('')` not dropped during minify

[hikerpig]

Describe the bug

When console is followed by optional chaining symbol ?, it will not be dropped during minify process.

Terser will remove it correctly.

Input code

console?.log('hello')

### Config

```json
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "tsx": false
    },
    "target": "es2015",

    "loose": true,
    "minify": {
      "compress": {
        "arguments": false,
        "arrows": true,
        "booleans": true,
        "booleans_as_integers": false,
        "collapse_vars": true,
        "comparisons": true,
        "computed_props": true,
        "conditionals": true,
        "dead_code": true,
        "directives": true,
        "drop_console": true,
        "drop_debugger": true,
        "evaluate": true,
        "expression": false,
        "hoist_funs": false,
        "hoist_props": true,
        "hoist_vars": true,
        "if_return": true,
        "join_vars": true,
        "keep_classnames": false,
        "keep_fargs": true,
        "keep_fnames": false,
        "keep_infinity": false,
        "loops": true,
        "negate_iife": true,
        "properties": true,
        "reduce_funcs": false,
        "reduce_vars": false,
        "side_effects": true,
        "switches": true,
        "typeofs": true,
        "unsafe": false,
        "unsafe_arrows": false,
        "unsafe_comps": false,
        "unsafe_Function": false,
        "unsafe_math": false,
        "unsafe_symbols": false,
        "unsafe_methods": false,
        "unsafe_proto": false,
        "unsafe_regexp": false,
        "unsafe_undefined": false,
        "unused": true,
        "const_to_let": true,
        "pristine_globals": true
      },
      "mangle": false
      
    },
  },
  "module": {
    "type": "es6"
  },
  "minify": true,
  "isModule": true
}

Playground link (or link to the minimal reproduction)

https://play.swc.rs/?version=1.9.3&code=H4sIAAAAAAAAA0vOzyvOz0m118vJT9dQz0jNyclX1%2BQCAGlpgzUWAAAA&config=H4sIAAAAAAAAA32US47bMAxA9z1F4PUs2gLtogformcQFItyNJVFQ6QyMQa5e2nZTtKE9iaI%2Bfgnxc8vh0PzTm3z6%2FApf%2BVjsJkg375FQmNiexFJw%2BMA1OYwcPO2UqYJeRsJqug6k4Zt7oAnK6DvX7%2F9EIsZREQCkXMusOj2IQU%2FPsZssR8yED3IRCouSw%2BJaY349sgyftB%2Ffqv8iBjBph1iLJmQGDrImuMWY7QDgTnbrHiZMrU5EGohJlgYnBkyDipPLnDAJDFfqQPrTIsOFBQytBzOoJlJLDFLJOVtUAfH0nV1zE8YzjYWy4ohXOpEJFmlSScMxMaXpHVwhhstmKHe2%2BBNBi45vaJ3DGnD6i%2BA1B8tUbI9aAlVDS%2FbtGXtdy1D8rKwPCpcllsrMkEnPTUheKWxU2Mgc9BmmcGVFqbGtlo6C1768EwpODDgvWyK4po%2BArcnLej0zNErQMZrawXPkWZgbm9wg0%2FPYQf%2FlipZ369Fo7d82qY09keMOwF64BO6HQUZBeM2znIjLsM2L8mBrAY4VaVQBa8nQPaf0cR6LV92Q16HeDRdxOP9SCwK19sV7m3q4m0yi%2FR%2Bj%2BtP06MrVWk59dOc5wP9s7krrbd4zaQJ9Gc1rLGv%2FwAQOon3NQYAAA%3D%3D

SWC Info output

No response

Expected behavior

It should be dropped.

Actual behavior

var _console;null==(_console=console)||_console.log("hello");

Version

1.9.3

Additional context

No response

[magic-akari]

In cases where the console might not be available, the correct way to write it is:

if (typeof console !== 'undefined') {
    console.log('Hello, world!');
}

Using console?.log will throw an error if console is not declared.

If this syntax appears, my best guess is: to evade the detection of the compressor, this line is made an exception and the syntax is slightly altered.

When the compressor covers this syntax and users still have needs, they might opt for the following code:

console['log']('Hello, world!');

I hope this doesn't turn into a battle between the compressor and users.
CC @kdy1

[CPunisher]

In cases where the console might not be available, the correct way to write it is:

if (typeof console !== 'undefined') {
    console.log('Hello, world!');
}

Using console?.log will throw an error if console is not declared.

If this syntax appears, my best guess is: to evade the detection of the compressor, this line is made an exception and the syntax is slightly altered.

When the compressor covers this syntax and users still have needs, they might opt for the following code:

console['log']('Hello, world!');

I hope this doesn't turn into a battle between the compressor and users. CC @kdy1

You are right.

We may need more information and context about why the users write console?.log. But it's very contradictory that they want keep some consoles while enabling drop_console.

drop_console is actually unsafe but widely supported. I guess that's because it's too useful and the corner cases rarely happen. So we may also need to weigh (to be aggressive or conservative).

The console['log']('Hello, world!'); is also removed with swc. So the user should find another dirty way...

[kdy1]

I think we can ignore the possibility of console being undeclared (or anything) if the user specified drop_console. IMHO, what they want is to ignore those possibilities. I used drop_conosle in the past because of IE, and the exact thinking was like,

Why do I need to check for the existence of a console? I wrote them for debugging. I don't care if an end-user looks at it.

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.