Skip to content

fix(es/minifier): Fix concat of unicode characters #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 26, 2025

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jun 26, 2025
@kdy1 kdy1 self-assigned this Jun 26, 2025
Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: 11e7c97

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Jun 26, 2025

CodSpeed Performance Report

Merging #10709 will create unknown performance changes

Comparing kdy1/10353 (11e7c97) with kdy1/fix-unicode-parser (0e6bab6)

Summary

🆕 141 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 css/visitor/compare/clone N/A 5.1 ms N/A
🆕 css/visitor/compare/fold_span N/A 6 ms N/A
🆕 css/visitor/compare/fold_span_panic N/A 6 ms N/A
🆕 css/visitor/compare/visit_mut_span N/A 5.4 ms N/A
🆕 css/visitor/compare/visit_mut_span_panic N/A 5.4 ms N/A
🆕 css/lexer/bootstrap_5_1_3 N/A 11.3 ms N/A
🆕 css/lexer/foundation_6_7_4 N/A 9.1 ms N/A
🆕 css/lexer/tailwind_3_1_1 N/A 1.8 ms N/A
🆕 css/parser/bootstrap_5_1_3 N/A 48.6 ms N/A
🆕 css/parser/foundation_6_7_4 N/A 38.4 ms N/A
🆕 css/parser/tailwind_3_1_1 N/A 7.5 ms N/A
🆕 es/codegen/colors N/A 70.4 µs N/A
🆕 es/codegen/large N/A 643.3 µs N/A
🆕 es/codegen/with-parser/colors N/A 167.5 µs N/A
🆕 es/codegen/with-parser/large N/A 1.3 ms N/A
🆕 es/lexer/angular N/A 10.7 ms N/A
🆕 es/lexer/backbone N/A 1.5 ms N/A
🆕 es/lexer/cal-com N/A 30.8 ms N/A
🆕 es/lexer/colors N/A 37.7 µs N/A
🆕 es/lexer/jquery N/A 8.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@kdy1 kdy1 marked this pull request as ready for review June 26, 2025 03:05
@kdy1 kdy1 requested review from a team as code owners June 26, 2025 03:05
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
@kdy1 kdy1 enabled auto-merge (squash) June 26, 2025 03:05
@kdy1 kdy1 disabled auto-merge June 26, 2025 03:21
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
@kdy1 kdy1 marked this pull request as draft June 26, 2025 03:33
@kdy1 kdy1 changed the title fix(es/codegen): Fix escape of unicode characters fix(es/minifier): Fix concat of unicode characters Jun 26, 2025
@kdy1 kdy1 marked this pull request as ready for review June 26, 2025 05:12
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 26, 2025
@kdy1 kdy1 marked this pull request as draft June 26, 2025 06:06
@kdy1 kdy1 changed the base branch from main to graphite-base/10709 June 27, 2025 05:54
@kdy1 kdy1 changed the base branch from graphite-base/10709 to kdy1/fix-unicode-parser June 27, 2025 05:55
Copy link
Member Author

kdy1 commented Jun 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 force-pushed the kdy1/fix-unicode-parser branch from 010cad0 to 0e6bab6 Compare June 27, 2025 05:56
@kdy1
Copy link
Member Author

kdy1 commented Jun 30, 2025

Closing in favor of #10734

@kdy1 kdy1 closed this Jun 30, 2025
@kdy1 kdy1 deleted the kdy1/10353 branch June 30, 2025 04:10
@kdy1 kdy1 modified the milestones: Planned, v1.12.8 Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SWC minifier un-escapes unicode characters
1 participant