Skip to content

refactor(swc_common): replace Option<Vec<Comment>> with Vec<Comment> #10785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CodeMan62
Copy link
Contributor

Description:
replace Option<Vec<Comment>> with Vec<Comment>

BREAKING CHANGE:
N/A

Related issue (if exists):
closes #10531

@CodeMan62 CodeMan62 requested review from a team as code owners July 6, 2025 12:24
Copy link

codspeed-hq bot commented Jul 6, 2025

CodSpeed Performance Report

Merging #10785 will not alter performance

Comparing CodeMan62:replace-option-vec-comment (dfd13cf) with main (8aa888b)

Summary

✅ 74 untouched benchmarks
⁉️ 66 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ es/minifier/libs/antd 2.1 s N/A N/A
⁉️ es/minifier/libs/d3 428.1 ms N/A N/A
⁉️ es/minifier/libs/echarts 1.6 s N/A N/A
⁉️ es/minifier/libs/jquery 107.1 ms N/A N/A
⁉️ es/minifier/libs/lodash 126.7 ms N/A N/A
⁉️ es/minifier/libs/moment 68.9 ms N/A N/A
⁉️ es/minifier/libs/react 21.7 ms N/A N/A
⁉️ es/minifier/libs/terser 379.1 ms N/A N/A
⁉️ es/minifier/libs/three 691.5 ms N/A N/A
⁉️ es/minifier/libs/typescript 4.2 s N/A N/A
⁉️ es/minifier/libs/victory 928.6 ms N/A N/A
⁉️ es/minifier/libs/vue 157.1 ms N/A N/A
⁉️ es/fixer/typescript 205.4 ms N/A N/A
⁉️ es/hygiene/typescript 454.4 ms N/A N/A
⁉️ es/resolver/typescript 253.4 ms N/A N/A
⁉️ es/resolver_with_hygiene/typescript 835.3 ms N/A N/A
⁉️ hygiene/typescript 22.8 s N/A N/A
⁉️ resolver/typescript 12.8 s N/A N/A
⁉️ es/transform/baseline/base 265.7 µs N/A N/A
⁉️ es/transform/baseline/common_reserved_word 290.8 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@CodeMan62 CodeMan62 marked this pull request as draft July 6, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use Vec<Comment> instead of Option<Vec<Comment>> in Comments trait
1 participant