fix(es/transforms/module/common_js): fix duplicate named exports iss…

[IronLu233]

totally fix (#1780)
This is from https://github.com/babel/babel/blob/b2d9156cc62d37f4c522c9505a00f50b99a1eb74/packages/babel-helper-module-transforms/src/index.ts#L206
and
https://github.com/babel/babel/blob/b2d9156cc62d37f4c522c9505a00f50b99a1eb74/packages/babel-helper-module-transforms/src/index.ts#L302

---

Closes #1780

[CLAassistant]

All committers have signed the CLA.

[kdy1]

I'm sorry but it's already fixed by #1829
I was wrong.

But the issue is already closed.

[IronLu233]

So should I need open a new issue for it?

[kdy1]

What do you are trying to fix?
If there are some unhandled edge cases left, I'll reopen the issue.

[IronLu233]

Please reopen the issue.
I want add if (key in exports && exports[key] === _File2[key]) return; in each named reexport.
If we don't have this judge, when two module have same named-export, the code will emit a error:

source:

export const BIZ = 'biz';
export * from './File1';
export * from './File2';

compile result of swc:

"use strict";
Object.defineProperty(exports, "__esModule", {
    value: true
});
var _exportNames = {
    BIZ: true
};
exports.BIZ = void 0;
var _file1 = require("./File1");
var _file2 = require("./File2");
function _interopRequireWildcard(obj) {
    if (obj && obj.__esModule) {
        return obj;
    } else {
        var newObj = {
        };
        if (obj != null) {
            for(var key in obj){
                if (Object.prototype.hasOwnProperty.call(obj, key)) {
                    var desc = Object.defineProperty && Object.getOwnPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : {
                    };
                    if (desc.get || desc.set) {
                        Object.defineProperty(newObj, key, desc);
                    } else {
                        newObj[key] = obj[key];
                    }
                }
            }
        }
        newObj.default = obj;
        return newObj;
    }
}
var BIZ = 'biz';
exports.BIZ = BIZ;
Object.keys(_file1).forEach(function(key) {
    if (key === "default" || key === "__esModule") return;
    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
    Object.defineProperty(exports, key, {
        enumerable: true,
        get: function() {
            return _file1[key];
        }
    });
});
Object.keys(_file2).forEach(function(key) {
    if (key === "default" || key === "__esModule") return;
    if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
    Object.defineProperty(exports, key, {
        enumerable: true,
        get: function() {
            return _file2[key];
        }
    });
});

compile result of babel:

"use strict";

Object.defineProperty(exports, "__esModule", {
  value: true
});
var _exportNames = {
  BIZ: true
};
exports.BIZ = void 0;

var _File = require("./File1");

Object.keys(_File).forEach(function (key) {
  if (key === "default" || key === "__esModule") return;
  if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
  if (key in exports && exports[key] === _File[key]) return;
  Object.defineProperty(exports, key, {
    enumerable: true,
    get: function () {
      return _File[key];
    }
  });
});

var _File2 = require("./File2");

Object.keys(_File2).forEach(function (key) {
  if (key === "default" || key === "__esModule") return;
  if (Object.prototype.hasOwnProperty.call(_exportNames, key)) return;
  if (key in exports && exports[key] === _File2[key]) return;
  Object.defineProperty(exports, key, {
    enumerable: true,
    get: function () {
      return _File2[key];
    }
  });
});
const BIZ = 'biz';
exports.BIZ = BIZ;

[IronLu233]

Hi, @kdy1 , I updated the branch and confirmed all unit test passed. Please approve the workflow.

[kdy1]

LGTM, thanks!