Additional Ransac Checks #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleeman
force-pushed
the
additional_ransac_checks
branch
from
6fcbd50 to
00b2c81
Compare
seth-swiftnav
approved these changes
Oct 22, 2019
Comment on lines
149
to
+151
| if (min_consensus_size >= groups.size() || | ||
| random_sample_size >= groups.size() || max_iterations <= 0) { | ||
| min_consensus_size < random_sample_size || | ||
| random_sample_size >= groups.size() || random_sample_size <= 0 || |
There was a problem hiding this comment.
nit: Transitivity makes the third equality redundant. :P
Looks good. No need to change.
sbmueller
pushed a commit
that referenced
this pull request
Nov 26, 2024
…iles [AP-3170] (#180) (#499) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 5b65c03c -> 30226aa8 - 30226aa8 : Add codeowners to guideline relevant files [AP-3170] (swift-nav/cmake#180) - 87ff9dfa : Revert "CMake patches for QNX Support (#178)" (swift-nav/cmake#179) - 5d9f739e : CMake patches for QNX Support (swift-nav/cmake#178) - fa934097 : Static bundles for the IAR toolchain[DRAFT] (swift-nav/cmake#177) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/18749/. [AP-3170]: https://swift-nav.atlassian.net/browse/AP-3170?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few additional checks to ransac before it gets run.