This repository was archived by the owner on Apr 13, 2021. It is now read-only.
I123 glo decoder error detector #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adel-mamin, please review. |
|
|
||
| return 0; /* The string is good */ | ||
|
|
||
| else if ((bit_set > 0 && !c_sum) |
There was a problem hiding this comment.
Should we remove 'else' here and below, since otherwise we always return?
There was a problem hiding this comment.
Yes. I'd prefer the else's removed, but it's not a big deal.
|
Looks good to me. |
dt-unikie
changed the title
| { | ||
| assert(n_bits <= 32 && n_bits > 0); | ||
| assert(bit_index <= 85 && bit_index > 0); | ||
| assert(bit_index <= GLO_STR_LEN && bit_index > 0); |
There was a problem hiding this comment.
Return error if parameters are invalid. Do not assert here.
| #include <libswiftnav/logging.h> | ||
| #include <libswiftnav/bits.h> | ||
|
|
||
| #ifdef UNIT_TEST |
There was a problem hiding this comment.
I'd prefer to move this to check_glo_decoder.c which includes this file.
#include <libswiftnav/logging.h>
#undef log_error
#define log_error(...)
#include "nav_msg_glo.c"
|
See my inline comments, but otherwise looks good. I haven't checked the algorithm, I'll take that on faith. |
|
Corrected. Thanks @gsmcmullin, @adel-mamin and @valeri-atamaniouk |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds error detection algorithm for GLO nav messages + unit tests.
Requires: https://github.com/swift-nav/libswiftnav/pull/329