test that connection close whilst idle works#167
Merged
Conversation
Motivation: I wasn't sure if we actually properly observed an idle connection suddenly closing. Ideally, if an idle connection just goes away, we just want to remove it from the connection pool (which is what happens). Modification: Add a test that verifies idle connections that get closed from the server don't get reused in the pool. Result: Better test coverage for more complicated scenarios.
Contributor
Author
|
CC @adtrevor |
artemredkin
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I wasn't sure if we actually properly observed an idle connection
suddenly closing. Ideally, if an idle connection just goes away, we just
want to remove it from the connection pool (which is what happens).
Modification:
Add a test that verifies idle connections that get closed from the
server don't get reused in the pool.
Result:
Better test coverage for more complicated scenarios.