fix validation error propagation#221
Merged
artemredkin merged 4 commits intoMay 20, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes request validation error propagation and use-after-shutdown, closes #217 and #220.
Motivation:
First issue is that validation errors are not passed to task fail methods. Second is that channel closed before connection is released from the pool, in this case clients will get wrong error (
remoteConnectionClosed) and connection will be released twice, potentially trying to execute stuff on a shutdown event loop.Modifications:
Result:
Error propagation is fixed.