fix test and a crash when closed#254
Merged
artemredkin merged 2 commits intoJun 15, 2020
Merged
Conversation
weissi
reviewed
Jun 15, 2020
| var state = HTTP1ConnectionProvider.ConnectionsState(eventLoop: self.eventLoop) | ||
| var snapshot = state.testsOnly_getInternalState() | ||
| snapshot.state = .closed | ||
| state.testsOnly_setInternalState(snapshot) |
Contributor
There was a problem hiding this comment.
can't we achieve this state by driving the state machine rather than forcing in a possibly illegal state?
Collaborator
Author
There was a problem hiding this comment.
ah, good catch, we can indeed, done, thanks! (also fixed a similar test above)
weissi
reviewed
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash in
testUncleanCloseThrows.Motivation:
This PR aims to fix two issues:
.closed, so it's a completely normal situatuonNIOHTTP1TestServer, where we wait for.headbefore we attempt to shutdown the client.Modifications:
testUncleanCloseThrowsto useNIOHTTP1TestServerto eliminate a raceConnectionState.swiftconnectFailedis working as expected when the client is.closedResult:
Closes #248