Fixes double-release of a connection.#295
Merged
artemredkin merged 2 commits intoAug 20, 2020
Merged
Conversation
Motivation: TaskHandler unconditionally releases it's connection on error, this can lead to double release. This issue actually indicates a more general issue where handler continues to handle errors even after its state is `.endOrError`. We need to fix this by ignoring all subsequent errors. Modifications: 1. Check state before calling out delegate and pool 2. Replace all error callouts with call to `errorCaught` Result: Fixes swift-server#294
artemredkin
force-pushed
the
fix_handler_error_after_error
branch
from
August 20, 2020 14:11
bb87dc8 to
4a5cc57
Compare
Lukasa
approved these changes
Aug 20, 2020
Lukasa
left a comment
Lukasa
left a comment
Collaborator
There was a problem hiding this comment.
Looks like a solid fix to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
TaskHandler unconditionally releases it's connection on error,
this can lead to double release. This issue actually indicates
a more general issue where handler continues to handle errors
even after its state is
.endOrError. We need to fix this byignoring all subsequent errors.
Modifications:
errorCaughtResult:
Fixes #294