[HTTP2] Tolerate GoAway and Settings frames after connection close #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Apr 11, 2022
Comment on lines
+262
to
+265
| case .closed: | ||
| // We may receive a events after we have called connection close, because of | ||
| // internal races. We should just ignore these cases. | ||
| return .nothing |
There was a problem hiding this comment.
@Lukasa Is this something that can happen? Should we be defensive here as well?
There was a problem hiding this comment.
This can happen, yes, unless we take action to defend against it. As we don't right now, it's a good idea to do this.
fabianfett
force-pushed
the
ff-tolerate-goaway
branch
from
be170b9 to
f7e1f16
Compare
Lukasa
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We may receive GoAway and Settings frames, even after a
context.close()was issued. For this reason, we must notpreconditionon the close state in ourHTTP2IdleHandler.StateMachine.Changes
Result
Fixes #575.