Replace TransactionBody with NIOAsyncSequenceProducer#677
Merged
Conversation
Conflicts: Sources/AsyncHTTPClient/AsyncAwait/HTTPClientResponse.swift Sources/AsyncHTTPClient/AsyncAwait/Transaction.swift Sources/AsyncHTTPClient/AsyncAwait/TransactionBody.swift
which currently fails because of apple/swift-nio#2398
Collaborator
Author
|
We now also throw |
glbrntt
approved these changes
Apr 12, 2023
glbrntt
left a comment
glbrntt
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good but I'm not super familiar with AHC.
Lukasa
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to properly respect task cancelation during the call to
HTTPClientResponse.Body.AsyncIterator.next().Modification
Replace our custom
AsyncSequenceimplementation by delegate most of the work toNIOAsyncSequenceProducerfromNIOCoreResult
We fully support cancelation throughout the stack and get the performance benefits of
NIOAsyncSequenceProducer.