Replace os() with canImport(Darwin)#693
Merged
Merged
Conversation
FranzBusch
approved these changes
Jun 22, 2023
Collaborator
|
@swift-server-bot add to allowlist |
Contributor
Author
|
@FranzBusch I've updated this branch but now the scope of this PR has change. Do I need to update the title? I think it'll be more clear for those who pass by. |
Collaborator
|
@swift-server-bot test this please |
Contributor
Author
|
@FranzBusch I think you need to approve this PR again. I made some changes yesterday, before your comment, and request a new review 😅 |
Lukasa
approved these changes
Jun 26, 2023
Collaborator
|
@swift-server-bot add to allowlist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increase the code verification with the right statement including all platforms that use Darwin.