Fix flaky test TransactionTests.testCancelAsyncRequest#707
Merged
dnadoba merged 8 commits intoOct 4, 2023
Merged
Conversation
Resolves swift-server#706. The continuation is resumed with the cancelation error before we cancel the scheduled request. https://github.com/swift-server/async-http-client/blob/62c06d47c8d21c91335e9f8998589e4ce31411e6/Sources/AsyncHTTPClient/AsyncAwait/Transaction.swift#L290C10-L294 Therefore this test is inherently flaky. The fix waits up to one second for the scheduled request to be canceled.
…com:dnadoba/async-http-client into dn-fix-flaky-test-test-cancel-async-request
Lukasa
approved these changes
Aug 14, 2023
Collaborator
Author
|
5.6 fails with not sure what is happening. |
Contributor
|
CI cleanup might have caused the doc check failure? @swift-server-bot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #706.
The continuation is resumed with the cancelation error before we cancel the scheduled request.
async-http-client/Sources/AsyncHTTPClient/AsyncAwait/Transaction.swift
Lines 290 to 294 in 62c06d4
Therefore this test is inherently flaky. The fix waits up to one second for the scheduled request to be canceled.