Skip to content

Fix wrong/outdated connect timeout documentation#714

Merged
Lukasa merged 1 commit into
swift-server:mainfrom
MahdiBM:patch-1
Oct 25, 2023
Merged

Fix wrong/outdated connect timeout documentation#714
Lukasa merged 1 commit into
swift-server:mainfrom
MahdiBM:patch-1

Conversation

@MahdiBM

@MahdiBM MahdiBM commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

The documentation states 30 seconds but other documentations and the implementation all agree on 10 seconds timeout as HTTPClient.Configuration.connect.

@dnadoba dnadoba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@Lukasa

Lukasa commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

@swift-server-bot test this please

@Lukasa Lukasa added the semver/none No version bump required. label Oct 25, 2023
@Lukasa Lukasa enabled auto-merge (squash) October 25, 2023 15:13
@Lukasa Lukasa merged commit 4824907 into swift-server:main Oct 25, 2023
@MahdiBM MahdiBM deleted the patch-1 branch October 25, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants