testPlatformConnectErrorIsForwardedOnTimeout port reuse#716
Merged
Conversation
Motivation: The above test has been seen to fail with port already in use. The test assumes that a port can be bound to twice in a row. It's possible that another process takes the port between the two binds - this can be stopped by binding a second time before stopping the first. Modifications: Allow port reuse and reorder the test to bind a second time before releasing the first. Result: Test should no longer be flaky.
dnadoba
approved these changes
Nov 2, 2023
dnadoba
left a comment
dnadoba
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for looking into this!
fabianfett
approved these changes
Nov 2, 2023
Collaborator
|
@swift-server-bot test this please |
1 similar comment
Collaborator
|
@swift-server-bot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The above test has been seen to fail with port already in use. The test assumes that a port can be bound to twice in a row. It's possible that another process takes the port between the two binds - this can be stopped by binding a second time before stopping the first.
Modifications:
Allow port reuse and reorder the test to bind a second time before releasing the first.
Result:
Test should no longer be flaky.