Fix OOM issue when setting concurrentHTTP1ConnectionsPerHostSoftLimit to Int.max#763
Merged
fabianfett merged 3 commits intoAug 14, 2024
Conversation
…t` to `Int.max` in HTTPClient.Configuration.ConnectionPool
fabianfett
reviewed
Aug 8, 2024
| XCTAssertNoThrow(try httpClient.syncShutdown()) | ||
| } | ||
|
|
||
| let response = httpClient.get(url: "https://localhost:\(bin.port)", deadline: .now() + .seconds(2)) |
Member
There was a problem hiding this comment.
we need to use the async/await API here.
fabianfett
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
When a user wishes to make the connection pool create as many concurrent connections as possible, a natural way to achieve this would be to set
.maxto theconcurrentHTTP1ConnectionsPerHostSoftLimitproperty.The
concurrentHTTP1ConnectionsPerHostSoftLimitproperty is of typeInt. Setting it toInt.maxleads toInt.maxbeing passed as an argument toArrays.reserveCapacity(_:)method, causing an OOM issue.Addresses Github Issue #751
Modifications:
Capped the argument to
self.connections.reserveCapacity(_:)to 1024 inHTTPConnectionPool.HTTP1ConnectionsResult:
Users can now set the
concurrentHTTP1ConnectionsPerHostSoftLimitproperty to.maxwithout causing an OOM issue.