Fix Connection Creation Crash#873
Merged
Merged
Conversation
glbrntt
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When creating a connection, we wrongfully assumed that
failedToCreateNewConnectionwill always be called beforehttp*ConnectionClosedin theHTTPConnectionPoolStateMachine. However this is far from correct. In NIO Futures are fulfilled beforeChannelHandlercallbacks. Ordering in futures should not be assumed in such a complex project.Change
We change the
http*ConnectionClosedmethods to be noops, if the connection is in the starting state. We instead wait for thefailedToCreateNewConnectionto create backoff timers and friends.rdar://164674912