Skip to content

redirects ignore EventLoop preference - issue#88#89

Merged
artemredkin merged 1 commit into
swift-server:masterfrom
ldewailly:issue#88_el_pref_on_redirect
Aug 21, 2019
Merged

redirects ignore EventLoop preference - issue#88#89
artemredkin merged 1 commit into
swift-server:masterfrom
ldewailly:issue#88_el_pref_on_redirect

Conversation

@ldewailly

Copy link
Copy Markdown

See #88 for details

let httpBin = HttpBin()
let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: 1)
let httpClient = HTTPClient(eventLoopGroupProvider: .shared(eventLoopGroup))
let eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: 5)

@ldewailly ldewailly Aug 21, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need more than 1 thread or this test is meaningless

@weissi weissi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@ldewailly ldewailly force-pushed the issue#88_el_pref_on_redirect branch from d04a722 to 9e82eeb Compare August 21, 2019 10:24
@artemredkin artemredkin merged commit 8814439 into swift-server:master Aug 21, 2019
@artemredkin

Copy link
Copy Markdown
Collaborator

Thank you @ldewailly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants