nest timeout configuration type inside configuration#93
Merged
Conversation
ktoso
reviewed
Aug 27, 2019
| self.connect = connect | ||
| self.read = read | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Could be a bit cleaner to either put the type into an extension or put it next to the other types defined here -- i.e. at the bottom of Configuration rather than on the top? When reading config I'm first interested in what fields it has after all 🤔
Collaborator
Author
There was a problem hiding this comment.
Good idea, thank!
Does it look like what you were thinking of?
ktoso
approved these changes
Aug 27, 2019
ktoso
left a comment
ktoso
left a comment
Contributor
There was a problem hiding this comment.
Thanks for following up :) Minor idea but LGTM in general 👍
ianpartridge
approved these changes
Aug 27, 2019
ktoso
approved these changes
Aug 27, 2019
ktoso
left a comment
ktoso
left a comment
Contributor
There was a problem hiding this comment.
Very nice, @artemredkin ! 👍
tomerd
approved these changes
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #92