Fix `Sendable` checking #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

stevapple wants to merge 1 commit into swift-server:main from stevapple:sendable-checking

Contributor

stevapple commented Dec 7, 2021 •

edited

Loading

Current state:

Sources/AWSLambdaRuntimeCore/LambdaContext.swift:28:20: error: stored property 'logger' of 'Sendable'-conforming struct 'InitializationContext' has non-sendable type 'Logger'
        public let logger: Logger
                   ^
Sources/AWSLambdaRuntimeCore/LambdaContext.swift:34:20: error: stored property 'eventLoop' of 'Sendable'-conforming struct 'InitializationContext' has non-sendable type 'EventLoop'
        public let eventLoop: EventLoop
                   ^
Sources/AWSLambdaRuntimeCore/LambdaContext.swift:37:20: error: stored property 'allocator' of 'Sendable'-conforming struct 'InitializationContext' has non-sendable type 'ByteBufferAllocator'
        public let allocator: ByteBufferAllocator
                   ^
Sources/AWSLambdaRuntimeCore/LambdaContext.swift:98:17: error: stored property 'storage' of 'Sendable'-conforming struct 'LambdaContext' has non-sendable type 'LambdaContext._Storage'
    private var storage: _Storage
                ^

We’re waiting for SwiftNIO and SwiftLog to fully support Sendable, meanwhile the design of LambdaContext should be adapted for Sendable.

WIP: Fix Sendable checking to pass nightly CI.

Motivation:

Add necessary Sendable conformance according to Swift Concurrency adoption guidelines for Swift Server Libraries (swift-server/guides#70).

Modifications:

Introduce LambdaSendable as a drop-in Sendable replacement that's compatible with prior Swift versions;
Conform LambdaHandler to Sendable;
Conform LambdaContext and Lambda.InitializationContext to LambdaSendable;
Require EventLoopLambdaHandler.Event and EventLoopLambdaHandler.Output to conform to LambdaSendable.

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

11 similar comments

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

swift-server-bot commented Dec 7, 2021

Can one of the admins verify this patch?

Contributor Author

stevapple commented Dec 7, 2021

I have only added necessary Sandable conformances for passing the compiler’s check. If there’s other type/protocol that should also conform to Sendable please let me know.

stevapple marked this pull request as draft

December 7, 2021 03:53


          Address Sendable checks

7f19403

stevapple force-pushed the sendable-checking branch from d602fa3 to 7f19403 Compare

December 7, 2021 03:57

Member

fabianfett commented Dec 7, 2021

@swift-server-bot test this please

stevapple closed this

stevapple deleted the sendable-checking branch

April 14, 2022 16:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet