Skip to content

Implement Add and Replace support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkz2 opened this issue Aug 2, 2023 · 0 comments · Fixed by #28
Closed

Implement Add and Replace support #25

dkz2 opened this issue Aug 2, 2023 · 0 comments · Fixed by #28

Comments

@dkz2
Copy link
Contributor

dkz2 commented Aug 2, 2023

The goal of this issue is to implement support for the Add and Replace operations. This will require us to add support for the following M(E) / M(R) Flags. We will also need to write unit test for Add and Replace request construction. An integration test where we open a connection with the Memcached server and test the Add and Replace functionality will also be included.

dkz2 added a commit to dkz2/swift-memcache-gsoc that referenced this issue Aug 6, 2023
FranzBusch pushed a commit that referenced this issue Aug 7, 2023
* add + replace #25

* soundness

* more test for add + replace

* build faiure fix?
FranzBusch pushed a commit that referenced this issue Aug 18, 2023
* add + replace #25

* soundness

* more test for add + replace

* build faiure fix?

* closes #26

* mr conflict clean up

* detla is now associated value

* precondition that both storage and arth mode are not set

* make sure of writeIntAsASCII

* closes #30

* soundness

* added unit test

* unit test refactor no string formatting

* MemcachedConnection clean up

* merge main update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant