Implement Delete Operation Support #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Aug 2, 2023
Comment on lines
271
to
274
| case .NF: | ||
| return false | ||
| default: | ||
| return false |
There was a problem hiding this comment.
I am kinda leaning towards throwing an error in the case where the key was not found. Also in the default case we should throw.
There was a problem hiding this comment.
In that case we probably do not need to return bool anymore?
FranzBusch
reviewed
Aug 2, 2023
| return false | ||
| throw MemcachedConnectionError.unexpectedNilResponse |
There was a problem hiding this comment.
We should throw a new error here to indicate that the key didn't exist
FranzBusch
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the need to extend our current Memcached functionality with the addition of a
deleteoperation. This operation allows users to remove specific key-value pairs from the cache directly. This PR will close #18.Motivation:
To broaden our interaction capabilities with Memcached servers. The
deleteoperation offers users more control over the stored data.Modifications:
DeleteCommandto ourMemcachedRequeststruct.MemcachedRequestEncoderto handledeleteoperation requestdeletemethod to ourMemcachedConnectionthat allows for deleting a key-value pair from memcached.Results:
With the addition of the
deleteoperation support, our API now allows users to directly remove key value pairs from cache, enhancing the versatility and control of data within the memcached server.