Remove [Lifecycle] prefix from log messages#95
Conversation
Motivation: Since Swift Log 1.3.0, log handlers can include the source of a particular message, rendering the [Lifecycle] prefix unnecessary. Modifications: Removed the [Lifecycle] prefix from all log messages by removing the underlying log helper and calling out to the Logger itself. Result: Log messages written by a log handler which includes the location wont log "Lifecycle" twice.
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
I created this as a draft for now as I'm not sure how to handle backward compatibility here. Any feedback is highly appreciated! |
|
@swift-server-bot add to allowlist |
|
personally, I think this is fine without backward compatibility. however if there is a consensus it is important you can make it into a configuration in 'Configuration' so folks can opt-in if they still want it |
|
@fabianfett @ktoso @yim-lee opinions? |
|
I don't think we need backwards compatibility for this lib. I support this change! |
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
LGTM :-)
I'm partial to this change as I suggested/requested @slashmo made the PR but yes, I think that's absolutely the right thing to do 👍
No concerns about compatibility, we don't guarantee stability of log messages like that.
5 participants
Motivation:
Since Swift Log 1.3.0, log handlers can include the source of a particular message,
rendering the [Lifecycle] prefix unnecessary.
Modifications:
Removed the [Lifecycle] prefix from all log messages by removing the underlying
log helper and calling out to the Logger itself.
Result:
Log messages written by a log handler which includes the location won't log "Lifecycle" twice.
Related: