Update build-script-helper.py to Python 3 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
benlangmuir
approved these changes
May 27, 2022
bnbarham
reviewed
May 27, 2022
| #!/usr/bin/env python | ||
|
|
||
| from __future__ import print_function | ||
| #!/usr/bin/env python3 |
There was a problem hiding this comment.
Depending on the python 3 version I'm not sure just this change is enough. It's fine for valid args but running with no args ends up with a stacktrace instead of error - I believe this is caused by the behavior of add_subparsers. It should now take required=True in Python >= 3.7.
bnbarham
reviewed
May 27, 2022
Utilities/build-script-helper.py
Outdated
| @@ -93,7 +91,7 @@ def add_common_args(parser): | |||
| parser.add_argument('--sanitize-all', action='store_true', help='build using every available sanitizer in sub-directories of build path') | |||
| parser.add_argument('--verbose', '-v', action='store_true', help='enable verbose output') | |||
|
|
|||
| subparsers = parser.add_subparsers(title='subcommands', dest='action', metavar='action') | |||
| subparsers = parser.add_subparsers(title='subcommands', dest='action', required=True, metavar='action') | |||
There was a problem hiding this comment.
Does PR CI run on Ubuntu 18.04? 3.7 was released in 2018, so wouldn't surprise me if it didn't have it.
There was a problem hiding this comment.
I just checked, they run Python 3.6.9 😬 I guarded the required=True option behind a Python version check.
bnbarham
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running locally, it looks like we just need to change the shebang.
#150