[lldb] Enable Swift Foundation value-type formatters on Windows#13212
Open
charles-zablit wants to merge 2 commits into
Open
[lldb] Enable Swift Foundation value-type formatters on Windows#13212charles-zablit wants to merge 2 commits into
charles-zablit wants to merge 2 commits into
Conversation
Author
|
@swift-ci please test |
Author
|
@swift-ci please test windows |
Author
|
@swift-ci please test macos |
Three things blocked the Foundation value-type tests on Windows:
1. The test inferiors could not launch: they depend on the Swift runtime DLLs
(Foundation, FoundationEssentials, swiftCore, ...), which are not on the
inferior's PATH. Windows has no rpath, so add the SDK's usr/bin (taken from
the test --sysroot) to the inferior PATH in the API test lit config.
2. The Data and UUID summary providers were registered for the exact type name
'Foundation.X' and so did not match the 'FoundationEssentials.X' types used
on Windows. Register them by regex, like Date and URL already are.
3. The Data summary provider only understood the legacy _Representation enum.
swift-foundation uses a struct (_storage: __DataStorage, _slice: Range<Int>)
whose byte count is the size of _slice. Read _slice's raw bytes (its
synthetic child provider is unreliable on Windows) and compute the count.
Re-enables foundation_value_types/{data,date,uuid} on Windows. Decimal (summary
provider needs the FoundationEssentials layout) and URL (swiftCore metadata
errors) need more work and stay disabled.
(cherry picked from commit ffb559b)
These lang/swift/explicit_modules tests (simple, implicit_fallback, private_type_generic) pass on Windows with the current toolchain, so remove their @skipIfWindows decorators. (cherry picked from commit af6bb99)
charles-zablit
force-pushed
the
cz/lldb/windows/re-enable-tests
branch
from
b5e6e26 to
15f3071
Compare
Author
|
@swift-ci please test windows |
Author
|
@swift-ci please test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 2296100)Three things blocked the Foundation value-type tests on Windows:
The test inferiors could not launch: they depend on the Swift runtime DLLs
(Foundation, FoundationEssentials, swiftCore, ...), which are not on the
inferior's PATH. Windows has no rpath, so add the SDK's usr/bin (taken from
the test --sysroot) to the inferior PATH in the API test lit config.
The Data and UUID summary providers were registered for the exact type name
'Foundation.X' and so did not match the 'FoundationEssentials.X' types used
on Windows. Register them by regex, like Date and URL already are.
The Data summary provider only understood the legacy _Representation enum.
swift-foundation uses a struct (_storage: __DataStorage, _slice: Range)
whose byte count is the size of _slice. Read _slice's raw bytes (its
synthetic child provider is unreliable on Windows) and compute the count.
Re-enables foundation_value_types/{data,date,uuid} on Windows. Decimal (summary
provider needs the FoundationEssentials layout) and URL (swiftCore metadata
errors) need more work and stay disabled.
(cherry picked from commit ffb559b)