[lldb] Remove SymbolFileDWARF assumption in DWARFASTParserSwiftDescri…#13214
Open
felipepiovezan wants to merge 1 commit into
Open
[lldb] Remove SymbolFileDWARF assumption in DWARFASTParserSwiftDescri…#13214felipepiovezan wants to merge 1 commit into
felipepiovezan wants to merge 1 commit into
Conversation
Author
|
@swift-ci test |
felipepiovezan
force-pushed
the
felipe/fixdsymvariantembeedded
branch
2 times, most recently
from
14dfd06 to
758836f
Compare
Author
|
@swift-ci test |
…ptorFinder A SymbolFile representing DWARF can be either a SymbolFileDWARF or a SymbolFileDWARFDebugMap. Prior to this commit DWARFASTParserSwiftDescriptorFinder assumed it would get a SymbolFileDWARF from the TypeSystem. By changing the query to obtain the SymbolFile from the `Type` itself (as opposed to `TypeSystem`), we can guarantee that the resulting SymbolFile will be a SymbolFileDWARF representing a specific object file. This was never discovered because our DWARF variants in embedded swift were still using dsyms.
felipepiovezan
force-pushed
the
felipe/fixdsymvariantembeedded
branch
from
758836f to
31ce34b
Compare
Author
|
Changed destination branch to 21.x |
Author
|
@swift-ci test |
Author
|
13:59:02 Timed Out Tests (1): |
Author
|
@swift-ci test macos platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ptorFinder
A SymbolFile representing DWARF can be either a SymbolFileDWARF or a SymbolFileDWARFDebugMap. Prior to this commit
DWARFASTParserSwiftDescriptorFinder assumed it would get a SymbolFileDWARF from the TypeSystem.
By changing the query to obtain the SymbolFile from the
Typeitself (as opposed toTypeSystem), we can guarantee that the resulting SymbolFile will be a SymbolFileDWARF representing a specific object file.This was never discovered because our DWARF variants in embedded swift were still using dsyms.
Existing tests are enough.
rdar://179813200