[lldb] Skip generic expression wrapping when no generics are in scope#13224
Open
kastiglione wants to merge 2 commits into
Open
Conversation
`MakeGenericSignaturesAndCalls` has been called unconditionally when `BindGenericTypes` is set to auto (the default), even when there are no metadata variables (generic parameters) in scope. This results in malformed Swift (empty generics ex `func $__lldb_user_expr<>`). This fails to parse, and causes an unnecessary retry. The fix is to gate this code path on `metadata_variables` being non-empty. Now, the generic wrapper is only used when generic parameters are present.
Author
|
@swift-ci test |
augusto2112
approved these changes
Jun 17, 2026
Author
|
@swift-ci test |
Author
|
@swift-ci test macOS |
1 similar comment
Author
|
@swift-ci test macOS |
Author
|
@swift-ci test windows |
5 similar comments
Author
|
@swift-ci test windows |
Author
|
@swift-ci test windows |
Author
|
@swift-ci test windows |
Author
|
@swift-ci test windows |
Author
|
@swift-ci test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change,
MakeGenericSignaturesAndCallswould be called unconditionally whenBindGenericTypesis set to auto (the default). For context-freepo, there are no metadata variables (generic parameters) in scope. This call sequence results in malformed Swift that contains empty generics (func $__lldb_user_expr<>). This fails to parse, and causes an unnecessary expression evaluation retry.The fix is to gate this code path on
metadata_variablesbeing non-empty. Now, the generic wrapper is only used when generic parameters are present.Assisted-by: claude