[lldb] fix arm64e tests not compiling with an arm64e target - #13847
Open
charles-zablit wants to merge 1 commit into
Open
[lldb] fix arm64e tests not compiling with an arm64e target#13847charles-zablit wants to merge 1 commit into
charles-zablit wants to merge 1 commit into
Conversation
charles-zablit
force-pushed
the
cz/lldb/fix-ptrauth-arch-cflags
branch
from
August 14, 2026 11:03
9774515 to
a174c56
Compare
adrian-prantl
left a comment
There was a problem hiding this comment.
This change also needs to be made on llvm.org and then cherry-picked here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm64eTestBase.build()only overrodeTRIPLE, butARCH_CFLAGSis a Make command-line variable set separately by the test harness to a non-arm64e flag. A plain in-Makefile assignment can't override a command-line variable, so the compiler silently fell back to the host's default (non-arm64e) triple and__ptrauthattributes failed to compile. Now overridesARCH_CFLAGStoo.Fixes: