[lldb][embedded] Keep clang typealiases when building field descriptors - #13907
Open
augusto2112 wants to merge 1 commit into
Open
[lldb][embedded] Keep clang typealiases when building field descriptors#13907augusto2112 wants to merge 1 commit into
augusto2112 wants to merge 1 commit into
Conversation
Author
|
@swift-ci test |
augusto2112
force-pushed
the
embedded-c-type-ivar
branch
from
August 17, 2026 23:49
2174c45 to
b68a46e
Compare
Author
|
@swift-ci test |
Typically, we want to canonicalize types before building field descriptors, as reflection metadata doesn't store field descriptors either. However, when building a descriptor for an aliased clang type, reflection metadata keeps the typelias, which it asks the type info provider to resolve. When building descriptors out of DWARF, match what reflection metadata does, and don't resolve clang typealiases when canonicalizing. Assisted-by: Claude rdar://185156293
augusto2112
force-pushed
the
embedded-c-type-ivar
branch
from
August 18, 2026 17:38
b68a46e to
be83ed0
Compare
Author
|
@swift-ci test |
Author
|
@swift-ci test Windows |
adrian-prantl
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically, we want to canonicalize types before building field
descriptors, as reflection metadata doesn't store field descriptors
either. However, when building a descriptor for an aliased clang type,
reflection metadata keeps the typelias, which it asks the type info
provider to resolve. When building descriptors out of DWARF, match what
reflection metadata does, and don't resolve clang typealiases when
canonicalizing.
Assisted-by: Claude
rdar://185156293