[clang][modules] Avoid modules diagnostics for __has_include()#7760
Merged
jansvoboda11 merged 1 commit intostable/20230725from Nov 7, 2023
Merged
Conversation
…m#71450) After llvm#70144 Clang started resolving module maps even for `__has_include()` expressions. This had the unintended consequence of emitting diagnostics around header misuse. These don't make sense if you actually don't bring contents of the header into the importer, so should be skipped for `__has_include()`. This patch moves emission of these diagnostics out of `Preprocessor::LookupFile()` up into `Preprocessor::LookupHeaderIncludeOrImport()`. (cherry picked from commit bdb309c)
Author
|
@swift-ci please test |
Author
|
@swift-ci please test Windows platform |
Author
|
Merging is blocked due to Windows failure tracked here: swiftlang/swift#69687 |
|
@swift-ci please test Windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm#70144 Clang started resolving module maps even for
__has_include()expressions. This had the unintended consequence of emitting diagnostics around header misuse. These don't make sense if you actually don't bring contents of the header into the importer, so should be skipped for__has_include(). This patch moves emission of these diagnostics out ofPreprocessor::LookupFile()up intoPreprocessor::LookupHeaderIncludeOrImport().(cherry picked from commit bdb309c)