Fix 40056: Prevent outlining of blocks with token type instructions (… #9005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm#99759) Hot cold splitting should not outline: 1. Basic blocks with token type instructions 1. Functions with scoped EH personality (As suggested by Vedant in llvm#40056 (comment)) Fixes: llvm#40056 (cherry picked from commit c59ee7e) (cherry picked from commit 267c6ed)
|
@swift-ci please test |
|
Explanation: Avoid performing HCS on certain constructs where the results are unlikely to be valuable and cause invalid IR to be formed. |
|
CC: @bnbarham |
fredriss
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…llvm#99759)
Hot cold splitting should not outline:
Fixes: llvm#40056
(cherry picked from commit c59ee7e) (cherry picked from commit 267c6ed)