-
Notifications
You must be signed in to change notification settings - Fork 339
Workaround invalid reloc 315 on aarch64 Linux #9339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we expose this as a flag instead? I don't think that we should be making this change. We are also hitting this on Android and are "working around" it by using the just built lld.
I'd prefer to get this change in to unblock rebranch, then see what the outcome of llvm#78003 (comment) ends up being (and either cherry-picking that, or using the flag if it's added). Is that reasonable to you? |
@swift-ci please test llvm |
`gold` fails to link `libswiftDispatch.so` on aarch64 Linux due to: ``` /usr/bin/ld.gold: error: Invalid/unrecognized reloc reloc 315. /usr/bin/ld.gold: internal error in global, at ../../gold/aarch64.cc:6398 clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. ``` Attempt to workaround this via disabling `SupportIndirectSymViaGOTPCRel`. rdar://135050296
35ca11f
to
0614ff9
Compare
@swift-ci please test |
I'd like to get this in ASAP as we have no idea if there's downstream aarch64 failures - I should have merged this last week really 😅. I agree passing a flag through probably makes more sense, so we can look at that separately. |
Failure is unrelated - it just started failing on tip. |
@swift-ci please test llvm |
In swiftlang#9339/0614ff994a the behavior was partially reverted.
In #9339/0614ff994a the behavior was partially reverted.
gold
fails to linklibswiftDispatch.so
on aarch64 Linux due to:Attempt to workaround this via disabling
SupportIndirectSymViaGOTPCRel
.rdar://135050296