-
Notifications
You must be signed in to change notification settings - Fork 339
[lldb] Support swiftlang tests with nested make invocations on Windows #9428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lldb] Support swiftlang tests with nested make invocations on Windows #9428
Conversation
f395779
to
42d409e
Compare
Haha, this is how to get attention. To all the new reviewers: sorry for the noise, this is still a boring patch. |
@swift-ci please test |
The Linux build failed, because the just-built Swift compiler hits an assertion in the standard library during CMake's "Check for working Swift compiler" step in swift-corelibs-libdispatch:
This is unrelated to my patch. LLDB built fine and testing didn't start yet. Previous premerge checks failed for the same reason since #9442 Edit: All still-visible failures here happened for the same reason: https://ci.swift.org/view/Swift%20rebranch/job/oss-swift-rebranch-lldb-linux-ubuntu-22_04/ |
@swift-ci please test Linux Platform |
Thanks. Rebranch linux is still broken. |
@swift-ci please test Linux Platform |
Perfect, I think this can land any time. |
Following the upstream patches llvm#112342 and llvm#112360, we can roll out the fix for the swiftlang-specific tests.