Skip to content

[lldb] Support swiftlang tests with nested make invocations on Windows #9428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weliveindetail
Copy link
Member

Following the upstream patches llvm#112342 and llvm#112360, we can roll out the fix for the swiftlang-specific tests.

@weliveindetail weliveindetail force-pushed the lldb-test-nested-make-path-space-fix branch from f395779 to 42d409e Compare October 18, 2024 17:12
@weliveindetail weliveindetail changed the base branch from next to stable/20240723 October 18, 2024 17:17
@weliveindetail
Copy link
Member Author

Haha, this is how to get attention. To all the new reviewers: sorry for the noise, this is still a boring patch.

@hjyamauchi
Copy link

@swift-ci please test

@weliveindetail
Copy link
Member Author

weliveindetail commented Oct 21, 2024

The Linux build failed, because the just-built Swift compiler hits an assertion in the standard library during CMake's "Check for working Swift compiler" step in swift-corelibs-libdispatch:

swift-frontend: /home/build-user/swift/stdlib/public/runtime/AccessibleFunction.cpp:110:
void swift::addImageAccessibleFunctionsBlockCallbackUnsafe(const void *, const void *, uintptr_t):
Assertion `size % sizeof(AccessibleFunctionRecord) == 0 && "accessible function section not a multiple of AccessibleFunctionRecord"' failed.

This is unrelated to my patch. LLDB built fine and testing didn't start yet. Previous premerge checks failed for the same reason since #9442

Edit: All still-visible failures here happened for the same reason: https://ci.swift.org/view/Swift%20rebranch/job/oss-swift-rebranch-lldb-linux-ubuntu-22_04/

@hjyamauchi
Copy link

@swift-ci please test Linux Platform

@weliveindetail
Copy link
Member Author

Thanks. Rebranch linux is still broken.

@hjyamauchi
Copy link

@swift-ci please test Linux Platform

@weliveindetail
Copy link
Member Author

Perfect, I think this can land any time.

@hjyamauchi hjyamauchi merged commit 3294662 into swiftlang:stable/20240723 Oct 23, 2024
3 checks passed
@weliveindetail weliveindetail deleted the lldb-test-nested-make-path-space-fix branch October 24, 2024 11:58
JDevlieghere pushed a commit that referenced this pull request Dec 11, 2024
JDevlieghere pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants