Repository navigation
Change code actions to provide functionality through SyntaxRefactoringCodeActionProvider #2628
Description
Activity
Hmm, I'm not sure this is the right direction. I thought
SyntaxRefactoringCodeActionProvideris just a glue code to adoptSyntaxRefactorrefactorings toSyntaxCodeActionProvider. What's the benefit ofSyntaxRefactoringCodeActionProvider?Code owners discussed offline and we concluded that using
SyntaxRefactoringCodeActionProvideris preferable. So please disregard my previous comment.Reacted by Harsh
Currently, many of the code actions in
SwiftLanguageService/CodeActionsdirectly conform toSyntaxCodeActionProvider. For those for which it makes sense, I think we could avoid some boilerplate (and add some more structure) by making the code action conform toSyntaxRefactoringCodeActionProvideras well asSyntaxRefactoringCodeActionProvider, removing the explicit implementation ofcodeActions(in:)and instead rely on the synthesized version.As this is a learning-oriented task, please don’t address this purely by using an AI tool, as described in https://github.com/swiftlang/project-operations/blob/main/contributing/ai-tools.md#learning-oriented-contributions.