Implement test discovery for swift-testing tests for the textDocument/tests request
#1151
Conversation
ahoppen
force-pushed
the
ahoppen/swift-testing-discovery
branch
from
6ff5626 to
aae7668
Compare
ahoppen
force-pushed
the
ahoppen/swift-testing-discovery
branch
from
aae7668 to
ea6ba1d
Compare
ahoppen
changed the title
textDocument/tests request 🚥 #1149textDocument/tests request
|
@swift-ci Please test |
…t/tests` request This allows us to return swift-testing tests within a single document. It does not look for swift-testing tests workspace-wide (the `workspace/tests` request), which will be a follow-up PR.
ahoppen
force-pushed
the
ahoppen/swift-testing-discovery
branch
from
ea6ba1d to
1770204
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
There was a problem hiding this comment.
+ @grynspan and @stmontgomery for the swift-testing scanning.
| return true | ||
| } | ||
|
|
||
| self.isHidden = traitArguments.lazy |
There was a problem hiding this comment.
We probably don't need to scan for .hidden: it's an internal-only trait we use for our test fixtures, not one external developers can use.
There was a problem hiding this comment.
If we decide to not support .hidden, I’ll change it in a follow-up PR to unblock #1175
| @@ -15,6 +15,11 @@ import LSPLogging | |||
| import LanguageServerProtocol | |||
| import SwiftSyntax | |||
|
|
|||
| public enum TestStyle { | |||
There was a problem hiding this comment.
We call this Library in SwiftPM, FWIW. Consistency may be a good thing.
There was a problem hiding this comment.
I was hoping that we could maybe upstream this request to the LSP spec, at which point it would become language-agnostic. And at that point, I think it’s better to have a general term like Style instead of Library, which has more implications about build/etc structure.
There was a problem hiding this comment.
I don't feel strongly about either term. :)
This allows us to return swift-testing tests within a single document. It does not look for swift-testing tests workspace-wide (the
workspace/testsrequest), which will be a follow-up PR.