Adjustment for the removal of IncrementalEdit(offset:length:replacement:) 🤝 swift-syntax#2588
#1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent:)` This initializer was only introduced very recently since `IncrementalEdit` stores the replacement bytes instead of just the replacement length. We are now changing `IncrementalEdit` store the range it’s replacing as `Range<AbsolutePosition>` instead of `ByteSourceRange`. Companion of swiftlang/swift-syntax#2588
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 5, 2024
ahoppen
changed the title
IncrementalEdit(offset:length:replacement:)IncrementalEdit(offset:length:replacement:) 🤝 swift-syntax#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initializer was only introduced very recently since
IncrementalEditstores the replacement bytes instead of just the replacement length. We are now changingIncrementalEditstore the range it’s replacing asRange<AbsolutePosition>instead ofByteSourceRange.Companion of swiftlang/swift-syntax#2588