Unify logging of errors during position conversions #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
unify-position-conversion-error-logging
branch
from
27d4c2c to
a25b1d2
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
unify-position-conversion-error-logging
branch
from
a25b1d2 to
a499fa7
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Apr 5, 2024
Sources/SKSupport/LineTable.swift
Outdated
| // Line out of range. | ||
| logger.fault( | ||
| """ | ||
| Unable to get string index for \(line):\(utf16Column) because line is out of range \ |
There was a problem hiding this comment.
Probably obvious enough from the caller, but could help to add whether it's utf8 vs utf16 in all these messages. It's not super necessary for the line case, so maybe just add utf<n> in front of column for the column cases?
Instead of logging errors in position translation ad-hoc at the caller’s side (and ofter forgetting to do so), log these errors in `LineTable`. To be able to debug where the position conversion error is coming from, also log the file name and line number of the caller. rdar://125545620
ahoppen
force-pushed
the
unify-position-conversion-error-logging
branch
from
a499fa7 to
d62c4ce
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logging errors in position translation ad-hoc at the caller’s side (and ofter forgetting to do so), log these errors in
LineTable. To be able to debug where the position conversion error is coming from, also log the file name and line number of the caller.