Fix a race condition during the computation of uriToWorkspaceCache
#1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Apr 18, 2024
Sources/SKSupport/AsyncQueue.swift
Outdated
| @@ -169,6 +169,15 @@ extension AsyncQueue where TaskMetadata == Serial { | |||
| return self.async(priority: priority, metadata: Serial(), operation: operation) | |||
| } | |||
|
|
|||
| /// Executes the given `operation` and awaits its result. | |||
| @discardableResult | |||
| public func sync<Success: Sendable>( | |||
There was a problem hiding this comment.
Suggested change
| public func sync<Success: Sendable>( | |
| public func asyncResult<Success: Sendable>( |
Maybe? Seems weird to call it sync since it is really still async.
There was a problem hiding this comment.
I removed it and added await <xxx>.value instead. Turns out that one of the three calls benefited from using await <xxx>.valuePropagatingCancellation
See comment in `workspaceForDocument` that explains the race.
ahoppen
force-pushed
the
uri-to-workspace-cache-race-condition
branch
from
2f9e211 to
a6f74fc
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in
workspaceForDocumentthat explains the race.