Skip to content

Skip a few hover tests if sourcekitd doesn’t return raw documentation in cursor info #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 23, 2024

The formatting of these hover responses contains a newline if we don’t have a raw documentation response. Skip these tests if sourcekitd doesn’t return the raw documentation in cursor info, like we do with other tests in this file.

This ensures that all tests are passing in Xcode 15.4 again.

… in cursor info

The formatting of these hover responses contains a newline if we don’t have a raw documentation response. Skip these tests if sourcekitd doesn’t return the raw documentation in cursor info, like we do with other tests in this file.

This ensures that all tests are passing in Xcode 15.4 again.
@ahoppen ahoppen requested a review from bnbarham April 23, 2024 21:20
@ahoppen ahoppen requested a review from benlangmuir as a code owner April 23, 2024 21:20
@ahoppen
Copy link
Member Author

ahoppen commented Apr 23, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 30a3d69 into swiftlang:main Apr 24, 2024
3 checks passed
@ahoppen ahoppen deleted the skip-hover-tests-on-old-toolchains branch April 24, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants